Skip to content

ref(core): Remove duplicate logic in scope.update #11384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2024
Merged

ref(core): Remove duplicate logic in scope.update #11384

merged 1 commit into from
Apr 3, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 2, 2024 •
edited
Loading

Found when examining minified bundle for v8 (to see if treeshaking working properly everywhere).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 76.35 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) 67.62 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 71.46 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.18 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) 32.31 KB (-0.11% 🔽)
@sentry/browser (incl. browserTracingIntegration) 32.31 KB (-0.11% 🔽)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (-0.14% 🔽)
@sentry/browser (incl. feedbackModalIntegration) 31.45 KB (-0.14% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (-0.14% 🔽)
@sentry/browser (incl. sendFeedback) 27.42 KB (-0.15% 🔽)
@sentry/browser 22.57 KB (-0.18% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.34 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay) 66.09 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing) 32.41 KB (-0.15% 🔽)
CDN Bundle 23.8 KB (-0.23% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 206.1 KB (-0.15% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 96.75 KB (-0.32% 🔽)
CDN Bundle - uncompressed 70.24 KB (-0.44% 🔽)
@sentry/react (incl. Tracing, Replay) 67.6 KB (-0.06% 🔽)
@sentry/react 22.6 KB (-0.17% 🔽)

@AbhiPrasad AbhiPrasad requested review from a team, lforst and s1gr1d and removed request for a team April 2, 2024 23:24
@AbhiPrasad AbhiPrasad self-assigned this Apr 2, 2024
@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 2, 2024 23:25
@AbhiPrasad AbhiPrasad merged commit b7a7ca3 into develop Apr 3, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-scope-ref-update branch April 3, 2024 12:56
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
ref(core): Remove duplicate logic in scope.update (getsentry#11384)
3d992ef 
Found when examining minified bundle for v8 (to see if treeshaking
working properly everywhere).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

@s1gr1d s1gr1d Awaiting requested review from s1gr1d s1gr1d was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @mydea