Skip to content

test(e2e): Extract event-proxy-server into dev package #11427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2024
Merged

test(e2e): Extract event-proxy-server into dev package #11427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f406c98
test(e2e): Extract event-proxy-server into dev package
mydea Apr 4, 2024
4fd2415
use link instead of file
mydea Apr 4, 2024
3bfaf71
fix test?
mydea Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/angular-17/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"zone.js": "~0.14.3"
},
"devDependencies": {
"@sentry-internal/event-proxy-server": "link:../../../event-proxy-server",
"@angular-devkit/build-angular": "^17.1.1",
"@angular/cli": "^17.1.1",
"@angular/compiler-cli": "^17.1.0",
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/angular-17/start-event-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { startEventProxyServer } from './event-proxy-server';
import { startEventProxyServer } from '@sentry-internal/event-proxy-server';

startEventProxyServer({
port: 3031,
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/angular-17/tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '../event-proxy-server';
import { waitForError, waitForTransaction } from '@sentry-internal/event-proxy-server';

test('sends an error', async ({ page }) => {
const errorPromise = waitForError('angular-17', async errorEvent => {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/angular-17/tests/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/event-proxy-server';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/core';
import { waitForTransaction } from '../event-proxy-server';

test('sends a pageload transaction with a parameterized URL', async ({ page }) => {
const transactionPromise = waitForTransaction('angular-17', async transactionEvent => {
Expand Down
253 changes: 0 additions & 253 deletions ...kages/e2e-tests/test-applications/create-remix-app-express-vite-dev/event-proxy-server.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"react-dom": "^18.2.0"
},
"devDependencies": {
"@sentry-internal/event-proxy-server": "link:../../../event-proxy-server",
"@playwright/test": "^1.36.2",
"@remix-run/dev": "^2.7.2",
"@sentry/types": "latest || *",
Expand Down
2 changes: 1 addition & 1 deletion ...ckages/e2e-tests/test-applications/create-remix-app-express-vite-dev/start-event-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { startEventProxyServer } from './event-proxy-server';
import { startEventProxyServer } from '@sentry-internal/event-proxy-server';
startEventProxyServer({
port: 3031,
proxyServerName: 'create-remix-app-express-vite-dev',
Expand Down
2 changes: 1 addition & 1 deletion ...-tests/test-applications/create-remix-app-express-vite-dev/tests/behaviour-server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect, test } from '@playwright/test';
import { uuid4 } from '@sentry/utils';

import { waitForTransaction } from '../event-proxy-server';
import { waitForTransaction } from '@sentry-internal/event-proxy-server';

test('Sends two linked transactions (server & client) to Sentry', async ({ page }) => {
// We use this to identify the transactions
Expand Down
Loading