Skip to content

feat(core): Wrap cron withMonitor callback in withIsolationScope #11797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 25, 2024

Multiple cron jobs can run at the same time and they may run on a server where other work is being performed.

Wrapping the withMonitor callback in withIsolationScope ensures that scope and breadcrumbs for the cron tasks remain isolated.

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!

Maybe (can be in a follow up) we can add one or two tests for this, ensuring crons are properly isolated 🤔

@timfish
Copy link
Collaborator Author

timfish commented Apr 26, 2024

we can add one or two tests for this

I was actually in the middle of writing cron tests when I got distracted by isolation!

@AbhiPrasad AbhiPrasad merged commit 9a6c6a7 into develop Apr 26, 2024
@AbhiPrasad AbhiPrasad deleted the timfish/isolate-cron-invocation branch April 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants