Skip to content

ref(docs): Update migration guide to use --require/--import flag #11970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2024

Conversation

andreiborza
Copy link
Member

No description provided.

as your application is either natively in CJS, or compiled at build time to CJS (which is the case for most TypeScript
apps, for example), everything will work without any further setup.

ECMAScript Modules (ESM) are only supported for Node v18.19.0 onwards.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ECMAScript Modules (ESM) are only supported for Node v18.19.0 onwards.
Sentry supports ECMAScript modules (ESM) only for Node v18.19.0 onwards.

@@ -21,7 +21,7 @@ In an environment with multiple execution contexts (e.g. Node), you can setup mu
different contexts, like this:

```js
import * as Sentry from '@sentry/browser';
import * as Sentry from '@sentry/node';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lforst lforst changed the title ref(docs): Update migration to use --require/--import flag ref(docs): Update migration guide to use --require/--import flag May 10, 2024
Luca Forstner added 2 commits May 10, 2024 14:33
@lforst lforst merged commit deabca3 into develop May 10, 2024
28 checks passed
@lforst lforst deleted the ab/update-7-to-8-migration-guide branch May 10, 2024 14:52
andreiborza added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants