-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(docs): Update migration guide to use --require/--import flag #11970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
reviewed
May 10, 2024
as your application is either natively in CJS, or compiled at build time to CJS (which is the case for most TypeScript | ||
apps, for example), everything will work without any further setup. | ||
|
||
ECMAScript Modules (ESM) are only supported for Node v18.19.0 onwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
ECMAScript Modules (ESM) are only supported for Node v18.19.0 onwards. | |
Sentry supports ECMAScript modules (ESM) only for Node v18.19.0 onwards. |
@@ -21,7 +21,7 @@ In an environment with multiple execution contexts (e.g. Node), you can setup mu | |||
different contexts, like this: | |||
|
|||
```js | |||
import * as Sentry from '@sentry/browser'; | |||
import * as Sentry from '@sentry/node'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
lforst
approved these changes
May 10, 2024
andreiborza
added a commit
that referenced
this pull request
May 16, 2024
) Co-authored-by: Luca Forstner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.