fix(replay): Start replay in afterAllSetup instead of next tick
#12709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
This should hopefully fix some race conditions...
mydea
changed the title
afterAllSetup instead of next tick
mydea
force-pushed
the
fn/replayImmediateError
branch
from
bacf357 to
eeae961
Compare
andreiborza
approved these changes
Jul 1, 2024
Comment on lines
296
to
298
| if (!this._replay) { | ||
| return; | ||
| } |
s1gr1d
reviewed
Jul 2, 2024
| @@ -133,8 +134,8 @@ describe('Integration | coreHandlers | handleGlobalEvent', () => { | |||
|
|
|||
| it('tags errors and transactions with replay id for session samples', async () => { | |||
| const { replay, integration } = await resetSdkMock({}); | |||
| // @ts-expect-error protected but ok to use for testing | |||
| integration._initialize(); | |||
| integration['_initialize'](getClient()!); | |||
There was a problem hiding this comment.
omg this syntax 😅 Not wrong at all, just JS/TS 🙄 😆
There was a problem hiding this comment.
yeah, it is definitely weird, but I prefer this over having to do @ts-expect-error 😅
s1gr1d
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix some race conditions.
Instead of initializing replay in the next tick, do it in the current tick but in
afterAllSetup, to ensure this runs e.g. after the replay-canvas integration.Fixes #12707