ref(nuxt): Only use rollup for build #13138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
requested review from
lforst,
a team and
mydea
and removed request for
a team
size-limit report 📦
|
AbhiPrasad
approved these changes
Jul 31, 2024
s1gr1d
added a commit
that referenced
this pull request
Aug 2, 2024
Reverting the change in this PR: #13138 For the time being (until this is debugged and fixed), this change is reverted and the Nuxt module will still be built with the nuxt-module-builder. The changed build-setup led to an error in `nuxt dev` and the navigation in the E2E test apps did not work. The error message: ``` ERROR [worker reload] [worker init] Package import specifier "#internal/nitro/virtual/app-config" is not defined in package /Users/sigridh/Documents/DEV/sentry-javascript-examples/node_modules/nitropack/package.json imported from /Users/sigridh/Documents/DEV/sentry-javascript-examples/node_modules/nitropack/dist/runtime/config.mjs ``` Similar errors were reported here: - nuxt/content#2736 - nuxt/icon#204 - nuxt/nuxt#13801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Nuxt SDK was built with
@nuxt/module-builderand rollup. This made things complicated, as it created two separate folders in the build output which could not share code between each other.This setup removes the
@nuxt/module-builderand adds the module config to rollup.