Skip to content

fix(solidstart): Remove public DSN from README #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix(solidstart): Remove public DSN from README #13294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c5bd3
fix(solidstart): Remove public DSN from README
andreiborza Aug 9, 2024
accfb46
Remove unnecessary Sentry.init call in ErrorBoundary example
andreiborza Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/solidstart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Create an instrument file named `instrument.server.mjs` and add your initializat
import * as Sentry from '@sentry/solidstart';

Sentry.init({
dsn: 'https://[email protected]/4507459091824640',
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});
```
Expand Down Expand Up @@ -145,11 +145,6 @@ JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.
import * as Sentry from '@sentry/solidstart';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
Expand Down
Loading