null check stacks in isSameStacktrace #1339
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some libraries, such as Mapbox, throw errors that are malformed. They don't have the frames variable, which get used in "_isRepeatData".
This causes Raven.captureException to fail on the second call, on _isRepeatData when deduping errors. This is particularly nasty because it's occurring in the catch part of a try / catch.
Sample code:
Exception seen in FullStory:
I'm not sure what the preferred behavior is here (returning true or false), but it strikes me that returning false is safer.
Appreciate any feedback, thanks!