Skip to content

ci: Update actions/upload-artifact to v4 #13489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2024
Merged

ci: Update actions/upload-artifact to v4 #13489

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c35db2
ci: Update actions/upload-artifact to v4
mydea Aug 28, 2024
e9e44b4
rename
mydea Aug 28, 2024
725c297
fix name & retention
mydea Aug 28, 2024
03e80cd
only store on failure?
mydea Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ jobs:
with:
name: build-output
path: ${{ env.CACHED_BUILD_PATHS }}
retention-days: 7
retention-days: 4
compression-level: 6
overwrite: true

Expand Down Expand Up @@ -345,6 +345,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: ${{ github.sha }}
retention-days: 90
path: |
${{ github.workspace }}/packages/browser/build/bundles/**
${{ github.workspace }}/packages/replay-internal/build/bundles/**
Expand Down Expand Up @@ -597,11 +598,13 @@ jobs:
run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

- name: Upload Playwright Traces
uses: actions/upload-artifact@v3
if: always()
uses: actions/upload-artifact@v4
if: failure()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted this to only store these on failure, I think this is good enough? Then we do not have to store all the traces all the time when we do not need them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traces should in general only be generated on failure - making this kinda moot - but we will save the ci time for the job running I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jup, it seems to work, see here: https://github.com/getsentry/sentry-javascript/actions/runs/10593166442/attempts/1 there are two artifacts, for the two failed jobs.

with:
name: playwright-traces
name: playwright-traces-job_browser_playwright_tests-${{ matrix.bundle}}-${{matrix.project}}-${{matrix.shard || '0'}}
path: dev-packages/browser-integration-tests/test-results
overwrite: true
retention-days: 7

job_browser_loader_tests:
name: PW ${{ matrix.bundle }} Tests
Expand Down Expand Up @@ -647,11 +650,13 @@ jobs:
cd dev-packages/browser-integration-tests
yarn test:loader
- name: Upload Playwright Traces
uses: actions/upload-artifact@v3
if: always()
uses: actions/upload-artifact@v4
if: failure()
with:
name: playwright-traces
name: playwright-traces-job_browser_loader_tests-${{ matrix.bundle}}
path: dev-packages/browser-integration-tests/test-results
overwrite: true
retention-days: 7

job_check_for_faulty_dts:
name: Check for faulty .d.ts files
Expand Down Expand Up @@ -1261,6 +1266,7 @@ jobs:
with:
name: ${{ steps.process.outputs.artifactName }}
path: ${{ steps.process.outputs.artifactPath }}
retention-days: 7

job_compile_bindings_profiling_node:
name: Compile & Test Profiling Bindings (v${{ matrix.node }}) ${{ matrix.target_platform || matrix.os }}, ${{ matrix.node || matrix.container }}, ${{ matrix.arch || matrix.container }}, ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc' }}
Expand Down
Loading