Skip to content

feat: atomic @sentry/utils used only with submodule imports #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jun 26, 2018

  • Move jest.config.js into package.json so we can use rimraf in utils
  • Fix all @sentry/utils imports to use submodule imports
  • Fix tests

@HazAT HazAT requested a review from kamilogorek as a code owner June 26, 2018 11:21
@HazAT HazAT self-assigned this Jun 26, 2018
@codecov-io
Copy link

codecov-io commented Jun 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@50d0005). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1413   +/-   ##
========================================
  Coverage          ?   85.1%           
========================================
  Files             ?      32           
  Lines             ?     779           
  Branches          ?     127           
========================================
  Hits              ?     663           
  Misses            ?     110           
  Partials          ?       6
Impacted Files Coverage Δ
packages/core/src/base.ts 96.51% <100%> (ø)
packages/utils/src/object.ts 100% <100%> (ø)
packages/node/src/integrations/http.ts 54.9% <100%> (ø)
packages/node/src/integrations/console.ts 94.44% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d0005...75820e0. Read the comment docs.

@kamilogorek kamilogorek merged commit 3a0ec5d into master Jun 26, 2018
@kamilogorek kamilogorek deleted the feature/atomic-utils branch June 26, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants