-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Add detail to measure spans and add regression tests #16557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AbhiPrasad
merged 9 commits into
develop
from
cursor/re-implement-measure-detail-feature-with-tests-3841
Jun 13, 2025
Merged
feat(browser): Add detail to measure spans and add regression tests #16557
AbhiPrasad
merged 9 commits into
develop
from
cursor/re-implement-measure-detail-feature-with-tests-3841
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
0550701
to
b437a13
Compare
Lms24
approved these changes
Jun 12, 2025
Thanks for revisiting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #16237
In #16348 we had to revert the PR that added
detail
tomeasure
spans as attributes.measure API: https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure
detail: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceMeasure/detail
This was reverted because it was causing issues in firefox, specifically this error was being thrown
From debugging, this seems to be coming from a
DOMException
being thrown @https://developer.mozilla.org/en-US/docs/Web/API/DOMExceptionThis was re-implemented, and then we added tests to validate that this wouldn't break on firefox.