ref: Change hooks to use simple verbs instead of before/-ed pairs #2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jun 16, 2020
| @@ -252,7 +247,7 @@ export class Vue implements Integration { | |||
| } | |||
| }; | |||
|
|
|||
| const childHandler = (hook: Hook) => { | |||
| const childHandler = (hook: Hook, operation: Operation) => { | |||
There was a problem hiding this comment.
Is there an option we expose to make this per component? Like if a user wanted to track multiple hooks for a single component, but use the standard hooks: ['mount', 'update'] for everything else.
There was a problem hiding this comment.
No, it's all configured for the whole app right now. We might do this in the future though.
AbhiPrasad
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
We should add tests for this in the future (give my vote to using https://testing-library.com/docs/vue-testing-library/intro)
|
Oh yes before I forget, these lifecycles are only for Vue |
HazAT
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.