Skip to content

docs(ember): Mention tracesSampleRate in Ember docs #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 24, 2020

This PR adds a paragraph mentioning setting tracesSampleRate in the @sentry/ember readme.

I just spent way to much time trying to figure out why no performance data is sent, until I noticed that I have to manually set this property in my config :)

@mydea mydea requested a review from kamilogorek as a code owner September 24, 2020 09:02
@dashed dashed requested a review from k-fish September 24, 2020 11:06
@mydea mydea changed the title Mention tracesSampleRate in Ember docs docs(ember): Mention tracesSampleRate in Ember docs Sep 24, 2020
This should help new users get started faster by including what is needed for performance right away.
Copy link
Member

@k-fish k-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for that. I had a commit I didn't push that added it right to the config, since performance is enabled by default, it should be easier for people to get started with it always on and they can lower it for their production environment after.

@k-fish k-fish merged commit 57af9b1 into getsentry:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants