Skip to content

fix: Make sure that mongo method is thenable before calling it #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2021
Merged

fix: Make sure that mongo method is thenable before calling it #3173

merged 2 commits into from
Jan 14, 2021

Conversation

kamilogorek
Copy link
Contributor

Fixes #3127

@kamilogorek kamilogorek requested a review from a team January 14, 2021 09:30
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.99 KB (0%)
@sentry/browser - Webpack 20.83 KB (0%)
@sentry/react - Webpack 20.83 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.15 KB (0%)

rhcarvalho
rhcarvalho approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add tests to avoid regression?

rhcarvalho
rhcarvalho approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@kamilogorek kamilogorek merged commit 53e1df9 into master Jan 14, 2021
@kamilogorek kamilogorek deleted the mongo-thenable branch January 14, 2021 12:26
@krvajal
Copy link

krvajal commented Jan 14, 2021

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in MongoDB Tracing
3 participants
@kamilogorek @krvajal @rhcarvalho