Skip to content

fix(nextjs): Use NextApiHandler type in withSentry #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

fix(nextjs): Use NextApiHandler type in withSentry #3506

merged 1 commit into from
May 6, 2021

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 5, 2021 •
edited
Loading

This switches to using the built-in NextApiHandler type (which next provides) in the withSentry function used to wrap API handlers.

Fixes #3501.

@lobsterkatie lobsterkatie requested a review from kamilogorek as a code owner May 5, 2021 18:28
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.63 KB (+0.01% 🔺)
@sentry/browser - Webpack 21.5 KB (0%)
@sentry/react - Webpack 21.53 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.92 KB (0%)

HazAT
HazAT approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@HazAT HazAT merged commit b9d923e into master May 6, 2021
@HazAT HazAT deleted the kmclb-fix-nextjs-with-sentry-types branch May 6, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sentry/nextjs: withSentry API helper types incompatible with NextJS
2 participants
@lobsterkatie @HazAT