fix(react): Use history object for init transaction name #3609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating pageload transactions the current react router v4/v5 relies on global.location.pathname (global is the current window instance), which can produce inconsistent basenames. This can cause pageload transctions to be not paramaterized correctly. This patch fixes this by using history.location.pathname to generate pageload transaction names. This was tested locally to confirm changes.
HazAT
approved these changes
May 27, 2021
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating pageload transactions the current react
router v4/v5 relies on global.location.pathname (global
is the current window instance), which can produce
inconsistent basenames. This can cause pageload transctions
to be not paramaterized correctly.
This patch fixes this by using history.location.pathname
to generate pageload transaction names. This was tested locally
to confirm changes.
Closes #3595 #3107
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).