Skip to content

perf(angular): do not run change detection when capturing the exception #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2021
Merged

perf(angular): do not run change detection when capturing the exception #3618

merged 2 commits into from
Jun 4, 2021

Conversation

arturovt
Copy link
Contributor

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

See code comments.

@arturovt arturovt requested a review from kamilogorek as a code owner May 29, 2021 15:17
@kamilogorek kamilogorek merged commit 113be3a into getsentry:master Jun 4, 2021
@kamilogorek
Copy link
Contributor

I don't know enough about Angular, but both changes look reasonable, so I'll trust you on those :) Thanks!

@arturovt arturovt deleted the perf/angular-capture-exception branch June 4, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturovt @kamilogorek