Skip to content

chore(ci): Use node 12 on Size Check job. #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

chore(ci): Use node 12 on Size Check job. #4162

merged 1 commit into from
Nov 16, 2021

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Nov 16, 2021 •
edited
Loading

Size Limit job has been failing due to the outdated node version (10.x, which appears to be the default).
Making sure it uses 12.x.

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.49 KB (+0.02% 🔺)
@sentry/browser - Webpack 23.37 KB (0%)
@sentry/react - Webpack 23.4 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.93 KB (+0.02% 🔺)

@onurtemizkan onurtemizkan marked this pull request as ready for review November 16, 2021 14:19
AbhiPrasad
AbhiPrasad approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing this!

@AbhiPrasad AbhiPrasad merged commit 2118068 into master Nov 16, 2021
@AbhiPrasad AbhiPrasad deleted the onur/size-check-node-version branch November 16, 2021 14:46
onurtemizkan added a commit that referenced this pull request Dec 19, 2021
@onurtemizkan
chore(ci): Use node 12 on Size Check job. (#4162)
0273956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @AbhiPrasad