Skip to content

ci: Switch to getsentry/size-limit-action #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Dec 1, 2021

Previously we rebuilt all our assets for size-check, leading it to take 7-8 minutes. Switching to Sentry forks helps address this + makes the comparison more robust by leveraging GH artifacts.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

size-limit report

Path Base Size Current Size Change
@sentry/browser - CDN Bundle (gzipped) 0 B 22.49 KB added
@sentry/browser - Webpack 0 B 23.37 KB added
@sentry/react - Webpack 0 B 23.4 KB added
@sentry/nextjs Client - Webpack 0 B 49.73 KB added
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 0 B 29.93 KB added

@AbhiPrasad
Copy link
Member Author

Successful in 33s

😎

Thanks @billyvg

@AbhiPrasad AbhiPrasad requested a review from billyvg December 1, 2021 17:41
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 I don't remember what other changes were made in the fork, but just be aware there may have been some column cuts?

@AbhiPrasad
Copy link
Member Author

Yeah we'll run it on a couple of PRs after and see if anything comes up, can always revert/update the fork if needed.

@AbhiPrasad AbhiPrasad merged commit ba63f2b into master Dec 1, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-size-limit-time branch December 1, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants