fix(angular): Use ui category for span operations #4222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-fish
approved these changes
Dec 2, 2021
| @@ -224,7 +225,7 @@ export function TraceMethodDecorator(): MethodDecorator { | |||
| activeTransaction.startChild({ | |||
| description: `<${target.constructor.name}>`, | |||
| endTimestamp: now, | |||
| op: `angular.${String(propertyKey)}`, | |||
| op: `${ANGULAR_OP}.${String(propertyKey)}`, | |||
There was a problem hiding this comment.
Same thing as React comments, especially since we recommend low cardinality ops, we should probably only use the same exported const ops and consume them here.
There was a problem hiding this comment.
I agree, but not sure how to best start considering: 1) we have 0 tests for angular (lol) and 2) this matches existing behaviour.
The propertyKey should be a set of strings though, not uuids or unique names, so I think we still fit the low cardinality aspect.
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
As per the new spec in https://develop.sentry.dev/sdk/performance/span-operations/#js-frameworks, we now want to prefix our angular spans operations with `ui`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the new spec in https://develop.sentry.dev/sdk/performance/span-operations/#js-frameworks, we now want to prefix our angular spans operations with
ui.This in conjugation with the changes in getsentry/sentry#30363 will allow these
uispans to be categorized as part of operations breakdown.