Skip to content

build: Extract npm-run-all into main package.json #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

AbhiPrasad
Copy link
Member

As prep for unifying our package.json, let's move dependencies that every package uses into the root package.json.

This patch does that for the npm-run-all package.

There is an argument that we should remove npm-run-all, but that can be discussed at a later time.

@AbhiPrasad AbhiPrasad requested review from a team, rhcarvalho and sl0thentr0py and removed request for a team December 6, 2021 14:34
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

size-limit report

Path Base Size (cefc919) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 22.45 KB 22.45 KB +0.02% 🔺
@sentry/browser - Webpack 23.29 KB 23.29 KB 0%
@sentry/react - Webpack 23.32 KB 23.32 KB 0%
@sentry/nextjs Client - Webpack 47.98 KB 47.98 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.9 KB 29.9 KB +0.01% 🔺

@AbhiPrasad AbhiPrasad force-pushed the abhi-package-json-npm-run-all branch from bd637c1 to 34429ed Compare December 6, 2021 14:56
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 6, 2021 14:56
@AbhiPrasad AbhiPrasad merged commit 899d153 into master Dec 6, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-package-json-npm-run-all branch December 6, 2021 15:11
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
As prep for unifying our package.json, let's move dependencies that every package uses into the root `package.json`.

This patch does that for the `npm-run-all` package.

There is an argument that we should remove `npm-run-all`, but that can be discussed at a later time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants