chore(build): Remove misplaced fetch-depth
option in ember CI build
#4275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3610, a change was made to the ember tests in CI, to fix an unspecified problem with checking out the relevant commit for testing. Unfortunately, the change was added in the wrong spot. As a result,
Problem 1 was fixed in 9b5ab61#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721, by adding the option to the right spot (again, for an unspecified reason).
This PR fixes problem 2, by removing the option from the wrong spot.
Given the mystery surrounding the addition of
fetch-depth
in the first place, it also adds a TODO to reconsider if we need it once ember tests are again all passing.