ref(core): Extract _ensureBeforeSendRv into func #4288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
mitsuhiko
approved these changes
Dec 15, 2021
JonasBa
reviewed
Dec 15, 2021
AbhiPrasad
force-pushed
the
abhi-ensure-before-sendrv
branch
from
64cda8c to
ff7a388
Compare
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
Extract out protected method `_ensureBeforeSendRv` from `baseclient` as it doesn't use any class props - this helps save a small amount of bundle size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract out protected method
_ensureBeforeSendRvfrombaseclientas it doesn't use any class props - this helps save a small amount of bundle size.