ref(utils): refactor promisebuffer #4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/ref/promise-buffer
branch
from
d64f28a to
598896d
Compare
JonasBa
force-pushed
the
jb/ref/promise-buffer
branch
from
598896d to
29b6914
Compare
size-limit report
|
AbhiPrasad
reviewed
Dec 16, 2021
packages/utils/src/promisebuffer.ts
Outdated
| clearTimeout(capturedSetTimeout); | ||
| resolve(true); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| const promiseBuffer: PromiseBuffer<T> = { | ||
| _buffer: buffer, |
There was a problem hiding this comment.
do we have to expose the buffer as well?
There was a problem hiding this comment.
@AbhiPrasad nope, just dropped it. The buffer is stored as _buffer on BaseTransport which was misleading when I searched
JonasBa
force-pushed
the
jb/ref/promise-buffer
branch
from
6057902 to
4a7463f
Compare
AbhiPrasad
approved these changes
Dec 16, 2021
AbhiPrasad
approved these changes
Dec 16, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
* ref(utils): refactor promisebuffer * ref(utils): remove length and isReady from public api * ref(promisebuffer): remove _buffer * fix(lint): run linter * fix(promisebuffer): add back the promise buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.