test(browser): Add integration tests for startTransaction
#4343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
onurtemizkan
changed the title
startTransactionstartTransaction
onurtemizkan
force-pushed
the
onur/public-api-tests-start-transaction
branch
from
7a3174a to
a912187
Compare
onurtemizkan
force-pushed
the
onur/public-api-tests-start-transaction
branch
from
a912187 to
e5cb0d2
Compare
AbhiPrasad
reviewed
Dec 21, 2021
Comment on lines
18
to
19
| const eventData = await getSentryTransactionRequest(page, url); | ||
| const transaction = eventData[2] as Event; |
There was a problem hiding this comment.
We should be returning the correct type from the helpers.
eventData[0] and eventData[1] are probably sessions. We prob wanna filter those out in the helper's return value
… into onur/public-api-tests-start-transaction
AbhiPrasad
reviewed
Dec 22, 2021
| const request = (await Promise.all([page.goto(url || '#'), waitForSentryRequest(page, 'transaction')]))[1]; | ||
|
|
||
| // https://develop.sentry.dev/sdk/envelopes/ | ||
| const envelope = (request?.postData() as string) || ''; |
There was a problem hiding this comment.
Can we try catch wrap this logic and throw and error accordingly?
AbhiPrasad
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #4333