Skip to content

fix(integration-tests): Refactor countdown mechanism of getMultipleSentryRequests #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2021
Merged

fix(integration-tests): Refactor countdown mechanism of getMultipleSentryRequests #4360

merged 1 commit into from
Dec 22, 2021

Conversation

onurtemizkan
Copy link
Collaborator

🤷‍♂️
Switched to countdown, moved decrement inside try block and the race condition on Firefox seems to be gone.
Not a single idea why.
🤷‍♂️

@onurtemizkan onurtemizkan mentioned this pull request Dec 22, 2021
Merged
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (01161b0) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.72 KB 19.72 KB +0.01% 🔺
@sentry/browser - CDN Bundle (minified) 62.76 KB 62.77 KB +0.01% 🔺
@sentry/browser - Webpack 22.25 KB 22.25 KB 0%
@sentry/browser - Webpack - gzip = false 75.92 KB 75.92 KB 0%
@sentry/react - Webpack 22.29 KB 22.29 KB 0%
@sentry/nextjs Client - Webpack 46.41 KB 46.41 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.37 KB 28.37 KB +0.01% 🔺

AbhiPrasad
AbhiPrasad approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol mysterious

@AbhiPrasad AbhiPrasad merged commit 33d69d5 into master Dec 22, 2021
@AbhiPrasad AbhiPrasad deleted the onur/fix-get-multi-sentry-requests-flakes branch December 22, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @AbhiPrasad