ref(tracing): Reduce metrics bundle size #4432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
kamilogorek
approved these changes
Jan 21, 2022
| @@ -194,60 +194,11 @@ export class MetricsInstrumentation { | |||
| } | |||
|
|
|||
| transaction.setMeasurements(this._measurements); | |||
| this._tagMetricInfo(transaction); | |||
|
|
|||
| _tagMetricInfo(transaction, this._lcpEntry, this._clsEntry); | |||
There was a problem hiding this comment.
I believe we dont use _ for regular functions. Just private class members due to linting/mangling setup.
There was a problem hiding this comment.
Yeah this is just there due to copy paste, I'll change.
- Extract out function _tagMetricInfo - Update `addPerformanceNavigationTiming` function signature to avoid using object destructure - Small change to entryScriptSrc
AbhiPrasad
force-pushed
the
abhi-tracing-bundle-size
branch
from
3205257 to
e16aedf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_tagMetricInfo(rename totagMetricInfo)addPerformanceNavigationTimingfunction signature to avoidusing object destructure
Now that we have integration tests, can more confidently refactor this file :)