Skip to content

fix(tests): Make CLS web vital test less flaky #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

lobsterkatie
Copy link
Member

Despite the fact that we're using a toBeCloseTo() check rather than a toEqual() check on the integration test for recording a "poor" CLS web vital, that test seems to have a habit of failing in CI, by ending up being not quite close enough to the desired value.

This fixes that by widening the window of tolerance just slightly, hopefully enough to prevent the flakiness.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

size-limit report

Path Base Size (0b4fd16) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.68 KB 19.68 KB +0.01% 🔺
@sentry/browser - CDN Bundle (minified) 62.89 KB 62.9 KB +0.01% 🔺
@sentry/browser - Webpack 22.21 KB 22.21 KB 0%
@sentry/browser - Webpack - gzip = false 76.02 KB 76.02 KB 0%
@sentry/react - Webpack 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack 46.24 KB 46.24 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.22 KB 28.23 KB +0.02% 🔺

@lobsterkatie lobsterkatie merged commit 6d0bce9 into master Feb 2, 2022
@lobsterkatie lobsterkatie deleted the kmclb-web-vitals-fix-flaky-poor-CLS-test branch February 2, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants