chore(build): Remove unused instances of @rollup/plugin-commonjs
#4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-remove-unused-rollup-plugin-commonjs
branch
from
febfadb to
7011384
Compare
lobsterkatie
changed the title
@rollup/plugin-commonjs@rollup/plugin-commonjs
AbhiPrasad
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In four of the five packages in which we're using
@rollup/plugin-commonjs, it has no effect (removing it doesn't change the bundles at all). This makes sense, because nowhere in those four packages are we importing any CJS modules. This PR removes those extraneous plugin instances.(The exception is
@sentry/integrations, because theOfflineplugin importslocalforage, which is CJS. As a result, its rollup config hasn't been changed.)