Skip to content

chore: Fix links in 6.18.1 changelog entry #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

AbhiPrasad
Copy link
Member

No description provided.

@AbhiPrasad AbhiPrasad requested a review from Lms24 February 28, 2022 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022

size-limit report

Path Base Size (8c51e95) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.77 KB 19.77 KB +0.01% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63.47 KB 63.47 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.44 KB 18.44 KB +0.02% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.6 KB 56.6 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.2 KB 22.2 KB 0%
@sentry/browser - Webpack (minified) 76.36 KB 76.36 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.23 KB 22.23 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.4 KB 46.4 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.23 KB 27.23 KB +0.01% 🔺

Comment on lines +9 to +12
- fix(ember): use _backburner if it exists ([#4603](https://github.com/getsentry/sentry-javascript/pull/4603))
- feat(gatsby): Upgrade Sentry Webpack Plugin to 1.18.8 ([#4636](https://github.com/getsentry/sentry-javascript/pull/4636))
- feat(nextjs): Upgrade Sentry Webpack Plugin to 1.18.8 ([#4643](https://github.com/getsentry/sentry-javascript/pull/4643))
- fix(nextjs): webpack as optional peer-dependency ([#4634](https://github.com/getsentry/sentry-javascript/pull/4634))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Do we need these URL links here? Asking because some release notes do not have them (https://github.com/getsentry/sentry-javascript/releases/tag/6.17.6) while (most) others do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We started doing this after #4519 - to make reading https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md much easier

The discussion was raised with this issue #4493

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 28, 2022 14:23
@AbhiPrasad AbhiPrasad merged commit 53fb4a3 into master Feb 28, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-6.18.1-changelog-fix branch February 28, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants