ref(tracing): Remove BrowserTracing
logging flag default value
#4708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
BrowserTracing
integration, we use a flag as a way to delay logging a warning message from the constructor until we can guarantee the logger has been enabled. Until now, that flag defaulted tofalse
, which has prevented it from being treeshaken, even in non-debug bundles in which it's not otherwise touched.This PR makes the flag optional, and removes the default value. Since
undefined
is falsy there are no runtime behavior changes, but the fact that it's never used, not even to be set to a default value, allows it to be fully removed by treeshaking. Here's the difference in the non-minified, non-debug ES5 tracing bundle, before and after:Ref: https://getsentry.atlassian.net/browse/WEB-696