Skip to content

fix(integrations): Fix type/async errors in Offline tests #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

lobsterkatie
Copy link
Member

This fixes a number of longstanding types errors in the tests for the Offline integration. It also simplifies some of the async code (to avoid mixing async functions and done()) and changes a mock so it is no longer assigning to a read-only property.

Getting these fixed will help unmuddy the waters with respect to the Offline test errors which are cropping up in our TS upgrade.

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (2b5be64) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.49 KB 19.49 KB -0.01% 🔽
@sentry/browser - ES5 CDN Bundle (minified) 62.17 KB 62.17 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.12 KB 18.11 KB -0.02% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 55.5 KB 55.5 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.6 KB 22.6 KB 0%
@sentry/browser - Webpack (minified) 79.21 KB 79.21 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.63 KB 22.63 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 47.6 KB 47.6 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.36 KB 25.36 KB -0.01% 🔽
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.72 KB 23.72 KB -0.01% 🔽

@lobsterkatie lobsterkatie requested a review from Lms24 March 23, 2022 08:30
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for doing this. Seems like we were quite close yesterday, right? This will help a lot the TS upgrade. I checked out the branch locally and ran the tests - all tests passed 👍

@lobsterkatie lobsterkatie merged commit 20b3e38 into master Mar 23, 2022
@lobsterkatie lobsterkatie deleted the kmclb-fix-offline-integration-tests branch March 23, 2022 17:12
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants