fix(integrations): Fix type/async errors in Offline
tests
#4755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of longstanding types errors in the tests for the
Offline
integration. It also simplifies some of the async code (to avoid mixing async functions anddone()
) and changes a mock so it is no longer assigning to a read-only property.Getting these fixed will help unmuddy the waters with respect to the
Offline
test errors which are cropping up in our TS upgrade.