Skip to content

test(node): Add startTransaction integration tests. #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

onurtemizkan
Copy link
Collaborator

Part of: #4762

@onurtemizkan onurtemizkan added this to the Release Stability milestone Mar 25, 2022
@@ -1,4 +1,4 @@
import { assertSentryTransaction, getEnvelopeRequest, runServer } from '../../../utils';
import { assertSentryTransaction, getEnvelopeRequest, runServer } from '../../../../utils';

test.skip('should send a manually started transaction when @sentry/tracing is imported using namespace import.', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test still be skipped?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept that in case we decide to support this in future, can just delete though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s just delete for now

@AbhiPrasad AbhiPrasad merged commit 99aa705 into master Mar 28, 2022
@AbhiPrasad AbhiPrasad deleted the onur/node-int-tests-start-transaction branch March 28, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants