Skip to content

fix(nextjs): Update install-sentry-from-branch #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

kamilogorek
Copy link
Contributor

Add missing yarn build:types command.

Add missing `yarn build:types` command
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait this needs to go into 7.x

@kamilogorek
Copy link
Contributor Author

No, it works with the current version, just tested it :S

@AbhiPrasad
Copy link
Member

No, it works with the current version, just tested it :S

Yeah - but it means we have to rebase that back on to 7.x. Merging into 7.x and cherry-picking later is prob easier right?

@kamilogorek
Copy link
Contributor Author

Ah, sure, your call

@AbhiPrasad AbhiPrasad changed the base branch from master to 7.x April 26, 2022 14:53
@AbhiPrasad AbhiPrasad changed the base branch from 7.x to master April 26, 2022 14:53
@AbhiPrasad
Copy link
Member

could you cherry-pick this commit onto 7.x?

@kamilogorek kamilogorek changed the base branch from master to 7.x April 26, 2022 17:28
@kamilogorek
Copy link
Contributor Author

I think changing the base should be enough?

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

@AbhiPrasad AbhiPrasad merged commit dfbab1f into 7.x Apr 26, 2022
@AbhiPrasad AbhiPrasad deleted the nextjs-install-from-branch branch April 26, 2022 17:30
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants