Skip to content

ref: Remove unused _sendEvent method in base client #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2022
Merged

ref: Remove unused _sendEvent method in base client #5026

merged 1 commit into from
May 3, 2022

Conversation

lforst
Copy link
Contributor

@lforst lforst commented May 3, 2022

Removes _sendEvent method on base client that has become unnecessary.

@lforst lforst requested review from Lms24 and AbhiPrasad May 3, 2022 12:58
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.7 KB (-7.16% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.42 KB (-9.59% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.51 KB (-7.17% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.6 KB (-9.27% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.21 KB (-17.35% 🔽)
@sentry/browser - Webpack (minified) 62.08 KB (-24.03% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.23 KB (-17.39% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.9 KB (-10.73% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.52 KB (-5.99% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.1 KB (-5.67% 🔽)

Base automatically changed from lforst-remove-breadcrumbs-usage to 7.x May 3, 2022 13:40
@lforst lforst force-pushed the lforst-remove-useless-send-event branch from 54ccc8e to f730e56 Compare May 3, 2022 13:42
@lforst lforst merged commit 39553b5 into 7.x May 3, 2022
@lforst lforst deleted the lforst-remove-useless-send-event branch May 3, 2022 13:44
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref: Remove unused _sendEvent method in base client (#5026)
d772c67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @AbhiPrasad