Skip to content

ref(node): Improve Node manual test logging #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022

Conversation

lobsterkatie
Copy link
Member

This makes some small changes to the logs emitted by the manual tests in the node package, to make it a little cleaner and easier to see what's what.

Included changes:

  • Use colorize function from release health tests in all test suites.
  • Capture and display console logs in express test.
  • Standardize success message across test suites.
  • Use whitespace to separate each suite's logs from the next.

Before:

image

After:

image

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.78 KB (-6.77% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.38 KB (-9.65% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.54 KB (-6.99% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.61 KB (-9.26% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.33 KB (-16.83% 🔽)
@sentry/browser - Webpack (minified) 61.47 KB (-24.77% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.35 KB (-16.87% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.81 KB (-10.91% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.43 KB (-6.3% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23 KB (-6.05% 🔽)

@lobsterkatie lobsterkatie merged commit 1badac1 into 7.x May 12, 2022
@lobsterkatie lobsterkatie deleted the kmclb-improve-node-manual-test-logging branch May 12, 2022 08:25
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
This makes some small changes to the logs emitted by the manual tests in the node package, to make it a little cleaner and easier to see what's what.

Included changes:
- Use `colorize` function from release health tests in all test suites.
- Capture and display console logs in express test.
- Standardize success message across test suites.
- Use whitespace to separate each suite's logs from the next.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants