Skip to content

chore(nextjs): Increase client integration test timeout #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Sep 12, 2022

Lately our nextjs integration tests seem to be flakey, because sometimes at least one of the client-side tests times out. (See screenshot below.)

This doubles the timeout in hopes of fixing that problem.

image

Copy link

@ProKashif ProKashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@lobsterkatie lobsterkatie merged commit a7e3d32 into master Sep 12, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-increase-client-integration-test-timeout branch September 12, 2022 13:35
@lobsterkatie
Copy link
Member Author

@kamilogorek - This seems to have made zero difference - the tests are still timing out left and right. Any theories, since you're the one who wrote these originally?

@lforst
Copy link
Contributor

lforst commented Sep 13, 2022

Timeouts can also happen when a request is expected to be intercepted and is just not arriving or more likely a request was executed before we got a chance to intercept it. I think we should check if there is a possibility we have such race conditions, and if so how to prevent them.

@lobsterkatie
Copy link
Member Author

Timeouts can also happen when a request is expected to be intercepted and is just not arriving or more likely a request was executed before we got a chance to intercept it. I think we should check if there is a possibility we have such race conditions, and if so how to prevent them.

Yeah, to be fair, I haven't sat down and turned on debug mode and actually dug in much. If Kamil doesn’t see something obvious, that'll be the next step.

@kamilogorek
Copy link
Contributor

Can't give you any concrete answer here, as its most likely an issue with sending an actual request, and not with enough time to intercept it. As @lforst mentioned, without running tests through debug mode its almost impossible to determine the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants