ref(core): Move sentry breadcrumb logic into integration #6195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Nov 16, 2022
|
@timfish anything blocking from getting this in? |
|
Just need to add a test. Will get on this tomorrow when I'm back at my desk! |
|
Added a test! |
AbhiPrasad
approved these changes
Nov 30, 2022
timfish
force-pushed
the
fix/move-sentry-breadcrumb-logic
branch
from
4dcd9a4 to
4df43bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getIntegrationByIdis used to ensure that theBreadcrumbsintegration is not included in the bundle when it's not used.Moving this logic from the
BaseClientinto the integration should save further bundle size when theBreadcrumbsintegration is not used, especially sincegetEventDescriptionwill no longer be included too.