Skip to content

fix(replay): Streamline logger usage #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2022
Merged

fix(replay): Streamline logger usage #6305

merged 3 commits into from
Nov 28, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 25, 2022

This streamlines how we use logger in replay, as well as making sure everything is properly stripped out outside of debug builds.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Nov 25, 2022
@mydea mydea requested a review from Lms24 November 25, 2022 12:56
@mydea mydea self-assigned this Nov 25, 2022
Lms24
Lms24 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Side note: I think we can sooner or later also delete the flags.ts file because it doesn't seem to be used anywhere. (but this doesn't have to happen in this PR).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.53 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 83.65 KB (-0.08% 🔽)
@sentry/replay - Webpack (gzipped + minified) 83.67 KB (-0.08% 🔽)
@sentry/replay - Webpack (minified) 272.53 KB (+0.09% 🔺)

@mydea
Copy link
Member Author

mydea commented Nov 25, 2022

Nice, LGTM. Side note: I think we can sooner or later also delete the flags.ts file because it doesn't seem to be used anywhere. (but this doesn't have to happen in this PR).

Good point, I'll also remove that!

mydea added 2 commits November 28, 2022 09:21
@mydea
fix(replay): Streamline logger usage
2ba3a72 
This streamlines how we use `logger` in replay, as well as making sure everything is properly stripped out outside of debug builds.
@mydea
ref(replay): Remove unused flags.ts file
3f8a70d
@mydea mydea merged commit 7954cf3 into master Nov 28, 2022
@mydea mydea deleted the fn/replay-logger branch November 28, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24