build(replay): Streamline tsconfig & jest config #6399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Dec 5, 2022
| import { handleFetch } from '../../../src/coreHandlers/handleFetch'; | ||
| import { mockSdk } from './../..'; |
There was a problem hiding this comment.
I'm just wondering about this path, wouldn't you normally have to specify the file?
There was a problem hiding this comment.
Hmm yeah, should we make it ./../../index? WDYT? (Guess this applies at all places) - maybe a bit more explicit...!
| "noEmitOnError": false, | ||
| "esModuleInterop": true, | ||
| "resolveJsonModule": true, | ||
| "allowJs": true, |
There was a problem hiding this comment.
Interesting, I thought we'd need at least allowJs here because of the worker 🤔 but not complaining if we don't need it either 😅
There was a problem hiding this comment.
I think the worker is just loaded as plain text, not as actual js, that's why it works probably!
For symmetry with the other packages, just use proper import paths.
mydea
force-pushed
the
fn/replay-tsconfig
branch
from
0aa284b to
8f6d90b
Compare
mydea
force-pushed
the
fn/replay-tsconfig
branch
from
8f6d90b to
60682a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes some steps towards aligning tsconfig & jest config of replay with the rest of the packages.
@testimports in replayIMHO the goal should be to also re-export the jest config from
/jest/jest.config.js, but I ran into a bunch of issues with that - I think related to typescript, and jest.setup.ts 😬 But this should be OK as a first step.