Skip to content

3.2.0 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2016
Merged

3.2.0 #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 3.2.0
* CHANGE: Callbacks set via `setDataCallback`, `setShouldSendCallback` now receive any prior-set callback as the 2nd argument. See: https://github.com/getsentry/raven-js/pull/636
* CHANGE: Raven.js no longer passes a 'message' interface for exceptions. See: https://github.com/getsentry/raven-js/pull/632
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely worth mentioning version compatibility with Sentry server. Doesn't this change bump the server requirement to 8.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't even realize that was a server change. Hmm, what's the right move here given that this could be breaking for on-premise users. Do we go to a full version bump (4.0.0)?

cc @dcramer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does this mean the server will reject the event? Or just complain that the message interface is missing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure off hand, that's just why I raised the question. It may be completely fine, I just don't know without investigating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcramer says this is fine.

* CHANGE: Log level now recorded for "sentry" breadcrumbs. See: https://github.com/getsentry/raven-js/pull/633

## 3.1.1
* BUGFIX: Fix message truncation occurring before dataCallback is invoked. See: https://github.com/getsentry/raven-js/issues/605
* BUGFIX: Fix pushState error in Chrome Apps. See: https://github.com/getsentry/raven-js/issues/601
Expand Down
2 changes: 1 addition & 1 deletion bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "raven-js",
"version": "3.1.1",
"version": "3.2.0",
"dependencies": {},
"main": "dist/raven.js",
"ignore": [
Expand Down
2 changes: 1 addition & 1 deletion dist/plugins/angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */

/*
* Includes TraceKit
Expand Down
2 changes: 1 addition & 1 deletion dist/plugins/angular.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/plugins/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */

/*
* Includes TraceKit
Expand Down
2 changes: 1 addition & 1 deletion dist/plugins/console.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/plugins/ember.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */

/*
* Includes TraceKit
Expand Down
2 changes: 1 addition & 1 deletion dist/plugins/ember.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/plugins/require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */

/*
* Includes TraceKit
Expand Down
2 changes: 1 addition & 1 deletion dist/plugins/require.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 18 additions & 17 deletions dist/raven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! Raven.js 3.1.1 (34f456e) | github.com/getsentry/raven-js */
/*! Raven.js 3.2.0 (d052e7e) | github.com/getsentry/raven-js */

/*
* Includes TraceKit
Expand Down Expand Up @@ -150,7 +150,7 @@ Raven.prototype = {
// webpack (using a build step causes webpack #1617). Grunt verifies that
// this value matches package.json during build.
// See: https://github.com/getsentry/raven-js/issues/465
VERSION: '3.1.1',
VERSION: '3.2.0',

debug: false,

Expand Down Expand Up @@ -515,7 +515,10 @@ Raven.prototype = {
* @return {Raven}
*/
setDataCallback: function(callback) {
this._globalOptions.dataCallback = callback;
var original = this._globalOptions.dataCallback;
this._globalOptions.dataCallback = isFunction(callback)
? function (data) { return callback(data, original); }
: callback;

return this;
},
Expand All @@ -528,7 +531,10 @@ Raven.prototype = {
* @return {Raven}
*/
setShouldSendCallback: function(callback) {
this._globalOptions.shouldSendCallback = callback;
var original = this._globalOptions.shouldSendCallback;
this._globalOptions.shouldSendCallback = isFunction(callback)
? function (data) { return callback(data, original); }
: callback;

return this;
},
Expand Down Expand Up @@ -1126,12 +1132,11 @@ Raven.prototype = {
},

_processException: function(type, message, fileurl, lineno, frames, options) {
var stacktrace, fullMessage;
var stacktrace;

if (!!this._globalOptions.ignoreErrors.test && this._globalOptions.ignoreErrors.test(message)) return;

message += '';
fullMessage = (type ? type + ': ' : '') + message;

if (frames && frames.length) {
fileurl = frames[0].filename || fileurl;
Expand Down Expand Up @@ -1161,8 +1166,7 @@ Raven.prototype = {
stacktrace: stacktrace
}]
},
culprit: fileurl,
message: fullMessage
culprit: fileurl
}, options);

// Fire away!
Expand Down Expand Up @@ -1284,10 +1288,14 @@ Raven.prototype = {
auth.sentry_secret = this._globalSecret;
}

var exception = data.exception && data.exception.values[0];
this.captureBreadcrumb({
category: 'sentry',
message: data.message,
event_id: data.event_id
message: exception
? (exception.type ? exception.type + ': ' : '') + exception.message
: data.message,
event_id: data.event_id,
level: data.level || 'error' // presume error unless specified
});

var url = this._globalEndpoint;
Expand Down Expand Up @@ -1355,13 +1363,6 @@ Raven.prototype = {
request.send(JSON.stringify(opts.data));
},

// Note: this is shitty, but I can't figure out how to get
// sinon to stub document.createElement without breaking everything
// so this wrapper is just so I can stub it for tests.
_newImage: function() {
return document.createElement('img');
},

_logDebug: function(level) {
if (this._originalConsoleMethods[level] && this.debug) {
// In IE<10 console methods do not have their own 'apply' method
Expand Down
4 changes: 2 additions & 2 deletions dist/raven.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/raven.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/sri.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"@dist/raven.js": {
"hashes": {
"sha256": "YfJL5HnkAUb6LaT41WdeubM9tHcj1KLNZzv091O0kAA=",
"sha512": "rc2JMbKhV8x5vp/NPhCGMsrepxYezWg/Xyvb0saXLKNy8vC5unYVfMXxe6KS9WVhCPOIt12OoZDKDmohxpT60Q=="
"sha256": "l424R9SHtp9TbZqeaYBEAqbTK4GypSj13iR6w3Er1nE=",
"sha512": "jPVWiZXfhkVsdmExC8WQjD+sBgeipsaxylooysTGsMCtegPXqOqnh/8kstLhyh8suvIHX5FM1LRHZdgANvtfYQ=="
},
"type": null,
"integrity": "sha256-YfJL5HnkAUb6LaT41WdeubM9tHcj1KLNZzv091O0kAA= sha512-rc2JMbKhV8x5vp/NPhCGMsrepxYezWg/Xyvb0saXLKNy8vC5unYVfMXxe6KS9WVhCPOIt12OoZDKDmohxpT60Q==",
"integrity": "sha256-l424R9SHtp9TbZqeaYBEAqbTK4GypSj13iR6w3Er1nE= sha512-jPVWiZXfhkVsdmExC8WQjD+sBgeipsaxylooysTGsMCtegPXqOqnh/8kstLhyh8suvIHX5FM1LRHZdgANvtfYQ==",
"path": "dist/raven.js"
},
"@dist/raven.min.js": {
"hashes": {
"sha256": "kgc2mY6SdVCVixqDm9Jx5zGX+JAIYPWpXY6QJAzLmhE=",
"sha512": "0Idcd2pOWVAvkBPiODuHMMq8YxGsrAc2SsFvQEdpQ2QGrPf/9OE2dUlspBBGC5UvD4Y/rbpY74SCVIfQzBBv8g=="
"sha256": "wFrEe9hRl6lKZoUmCxgr0R1BbDylMR+wd40N7o5uEJM=",
"sha512": "TxMxb9gCA8dX5xDcgClofPznLatqqf/9KdZ7P+0TZUetJSl/4GdvPZ5zI0AndeQOqf5IXCOUpNGznb/AAyNcJA=="
},
"type": null,
"integrity": "sha256-kgc2mY6SdVCVixqDm9Jx5zGX+JAIYPWpXY6QJAzLmhE= sha512-0Idcd2pOWVAvkBPiODuHMMq8YxGsrAc2SsFvQEdpQ2QGrPf/9OE2dUlspBBGC5UvD4Y/rbpY74SCVIfQzBBv8g==",
"integrity": "sha256-wFrEe9hRl6lKZoUmCxgr0R1BbDylMR+wd40N7o5uEJM= sha512-TxMxb9gCA8dX5xDcgClofPznLatqqf/9KdZ7P+0TZUetJSl/4GdvPZ5zI0AndeQOqf5IXCOUpNGznb/AAyNcJA==",
"path": "dist/raven.min.js"
}
}
2 changes: 1 addition & 1 deletion docs/config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ Putting it all together
<body>
...
<script src="jquery.min.js"></script>
<script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
<script>
Raven.config('___PUBLIC_DSN___', {
logger: 'my-logger',
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ scripts. For all details see :doc:`install`.

.. sourcecode:: html

<script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>


Configuring the Client
Expand Down
4 changes: 2 additions & 2 deletions docs/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ So for example:
.. sourcecode:: html

<script src="jquery.js"></script>
<script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>
<script>Raven.config('___PUBLIC_DSN___').install();</script>
<script src="app.js"></script>

Expand All @@ -28,7 +28,7 @@ Our CDN distributes builds with and without :doc:`integrations <integrations/ind

.. sourcecode:: html

<script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>

This version does not include any plugins. See `ravenjs.com
<http://ravenjs.com/>`_ for more information about plugins and getting
Expand Down
2 changes: 1 addition & 1 deletion docs/integrations/angular.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Example:
.. sourcecode:: html

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>
<script src="https://cdn.ravenjs.com/3.1.1/angular/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/angular/raven.min.js"></script>
<script>Raven.config('___PUBLIC_DSN___').install();</script>

Note that this CDN build auto-initializes the Angular plugin.
Expand Down
2 changes: 1 addition & 1 deletion docs/integrations/backbone.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.

.. sourcecode:: html

<script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>

Configuring the Client
----------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/integrations/ember.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Example:
.. sourcecode:: html

<script src="http://builds.emberjs.com/tags/v2.3.1/ember.prod.js"></script>
<script src="https://cdn.ravenjs.com/3.1.1/ember/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/ember/raven.min.js"></script>
<script>Raven.config('___PUBLIC_DSN___').install();</script>

Note that this CDN build auto-initializes the Ember plugin.
Expand Down
2 changes: 1 addition & 1 deletion docs/integrations/react.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.

.. sourcecode:: html

<script src="https://cdn.ravenjs.com/3.1.1/raven.min.js"></script>
<script src="https://cdn.ravenjs.com/3.2.0/raven.min.js"></script>

Configuring the Client
----------------------
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "raven-js",
"version": "3.1.1",
"version": "3.2.0",
"license": "BSD-2-Clause",
"homepage": "https://getsentry.com",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/raven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Raven.prototype = {
// webpack (using a build step causes webpack #1617). Grunt verifies that
// this value matches package.json during build.
// See: https://github.com/getsentry/raven-js/issues/465
VERSION: '3.1.1',
VERSION: '3.2.0',

debug: false,

Expand Down
4 changes: 2 additions & 2 deletions test/raven.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ describe('globals', function() {
extra: {'session:duration': 100},
});
assert.deepEqual(opts.auth, {
sentry_client: 'raven-js/3.1.1',
sentry_client: 'raven-js/3.2.0',
sentry_key: 'abc',
sentry_version: '7'
});
Expand Down Expand Up @@ -1006,7 +1006,7 @@ describe('globals', function() {
extra: {'session:duration': 100},
});
assert.deepEqual(opts.auth, {
sentry_client: 'raven-js/3.1.1',
sentry_client: 'raven-js/3.2.0',
sentry_key: 'abc',
sentry_secret: 'def',
sentry_version: '7'
Expand Down