Skip to content

fix(replay): Add CDN bundle path to release artifacts #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 7, 2022

So, turns out, CDN bundles are not released automatically (I should have known...)

Craft uses the release artifacts zip generated by our "Upload Artifacts" job to search for files to upload. Our bundle path (packages/replay/build/bundles) wasn't added to this job's config so it wasn't included in the release.

This PR fixes that and it also adds an entry to our release checklist. It furthermore bumps the minimum version for the CDN bundles in the Replay README. Docs should automatically pick up the newest version, so we don't need to bump anything in getsentry/sentry-docs#5899

Note: I still think we don't need to add anything to the Craft config, as it seems like craft is picking up all JS files in the artifacts zip and uploads the to GCS

@Lms24 Lms24 requested review from mydea and AbhiPrasad December 7, 2022 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.67 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.94 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.46 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.49 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.26 KB (0%)
@sentry/browser - Webpack (minified) 66.24 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.29 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.14 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.53 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.96 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.8 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.91 KB (0%)

@Lms24 Lms24 merged commit 0942281 into master Dec 7, 2022
@Lms24 Lms24 deleted the lms-replay-build-artifacts branch December 7, 2022 11:37
@Lms24 Lms24 added the Package: replay Issues related to the Sentry Replay SDK label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants