Skip to content

test(ember): Ensure tests are not flaky due to long tasks #6836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

test(ember): Ensure tests are not flaky due to long tasks #6836

merged 1 commit into from
Jan 18, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 18, 2023

Closes #6834

@mydea mydea added Package: ember Issues related to the Sentry Ember SDK Type: Tests labels Jan 18, 2023
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 18, 2023 10:32
@mydea mydea self-assigned this Jan 18, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.51 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.73 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.02 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.12 KB (-0.82% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.45 KB (-1% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.35 KB (-0.6% 🔽)

@mydea mydea enabled auto-merge (squash) January 18, 2023 10:39
@mydea mydea merged commit 8b3a576 into master Jan 18, 2023
@mydea mydea deleted the fn/ember-flaky-test branch January 18, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
Package: ember Issues related to the Sentry Ember SDK Type: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: Ember embroider Sentry Performance: Test navigating to slow route
2 participants
@mydea @AbhiPrasad