Skip to content

test(core): Try again to fix offline test flake #7092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 8, 2023

Another attempt at fixing #7079

This time I'll re-run the tests a few times to make sure it's not flakey still!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Replay SDK metrics 🚀

Latest data for: 6462b00
  Plain +Sentry +Replay
Value Value Diff Ratio Value Diff Ratio
LCP 71.03 ms 93.36 ms +22.33 ms +31.43 % 133.21 ms +62.18 ms +87.53 %
CLS 0.06 ms 0.06 ms +0.00 ms +0.03 % 0.06 ms +0.00 ms +0.47 %
CPU 12.80 % 15.62 % +2.82 pp +22.01 % 36.50 % +23.70 pp +185.10 %
JS heap avg 1.94 MB 1.99 MB +51.27 kB +2.65 % 3.04 MB +1.1 MB +56.83 %
JS heap max 2.3 MB 2.57 MB +263.74 kB +11.45 % 4.53 MB +2.23 MB +96.78 %
netTx 0 B 0 B 0 B n/a 2.57 kB +2.57 kB n/a
netRx 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount 0 0 0 n/a 1 +1 n/a
netTime 0.00 ms 0.00 ms 0.00 ms n/a 117.17 ms +117.17 ms n/a

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 08 Feb 2023 14:04:32 GMT

@timfish timfish closed this Feb 9, 2023
@timfish timfish reopened this Feb 9, 2023
@AbhiPrasad AbhiPrasad merged commit bc942ae into getsentry:develop Feb 9, 2023
@timfish timfish deleted the fix/offline-test-flake branch February 9, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants