Skip to content

chore(replay): Link to Docs for CDN bundle installation #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 8, 2023

Following up on a slack discussion with @bruno-garcia, we're going to remove the CDN installation section from the Replay package README.md. This section has always been problematic because we can't keep it in sync with the latest SDK version and its integrity checksum. Instead, we now just link to Sentry Docs for the CDN setup, which contains the latest version and checksum.

I put the deprecation notice of the two separate CDN bundles under a spoiler as this is the only place where we still mention this installation method.

@Lms24 Lms24 self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR 5c937aa 74.77 ms 101.57 ms +26.79 ms +35.83 % 130.27 ms +55.49 ms +74.21 %
Previous 45638e4 88.20 ms 128.36 ms +40.16 ms +45.53 % 160.00 ms +71.80 ms +81.41 %
CLS This PR 5c937aa 0.06 ms 0.06 ms -0.00 ms -0.31 % 0.06 ms +0.00 ms +0.54 %
Previous 45638e4 0.06 ms 0.06 ms -0.00 ms -0.04 % 0.06 ms +0.00 ms +0.01 %
CPU This PR 5c937aa 13.96 % 13.27 % -0.70 pp -4.99 % 28.44 % +14.47 pp +103.62 %
Previous 45638e4 20.63 % 22.09 % +1.46 pp +7.08 % 42.57 % +21.94 pp +106.31 %
JS heap avg This PR 5c937aa 1.93 MB 2 MB +65.98 kB +3.41 % 3.02 MB +1.08 MB +56.07 %
Previous 45638e4 1.93 MB 2 MB +68.89 kB +3.56 % 3.03 MB +1.1 MB +56.71 %
JS heap max This PR 5c937aa 2.3 MB 2.58 MB +272.13 kB +11.81 % 4.53 MB +2.22 MB +96.54 %
Previous 45638e4 2.3 MB 2.56 MB +261.89 kB +11.37 % 4.57 MB +2.26 MB +98.25 %
netTx This PR 5c937aa 0 B 0 B 0 B n/a 2.61 kB +2.61 kB n/a
Previous 45638e4 0 B 0 B 0 B n/a 2.61 kB +2.61 kB n/a
netRx This PR 5c937aa 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous 45638e4 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR 5c937aa 0 0 0 n/a 1 +1 n/a
Previous 45638e4 0 0 0 n/a 1 +1 n/a
netTime This PR 5c937aa 0.00 ms 0.00 ms 0.00 ms n/a 68.14 ms +68.14 ms n/a
Previous 45638e4 0.00 ms 0.00 ms 0.00 ms n/a 98.15 ms +98.15 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
45638e4+71.80 ms+0.00 ms+21.94 pp+1.1 MB+2.26 MB+2.61 kB+41 B+1+98.15 ms
b539b36+53.97 ms-0.00 ms+16.53 pp+1.12 MB+2.23 MB+2.61 kB+41 B+1+114.29 ms
6462b00+62.18 ms+0.00 ms+23.70 pp+1.1 MB+2.23 MB+2.57 kB+41 B+1+117.17 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 08 Feb 2023 17:46:41 GMT

@Lms24 Lms24 merged commit 11e6f09 into develop Feb 9, 2023
@Lms24 Lms24 deleted the lms-replay-update-readme-cdn branch February 9, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants