ci: Ensure we can actually run size-limit for release branches #7214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on getsentry/size-limit-action#8, this ensures we can actually run size-limit on release branches, which currently fails.
size-limit report 📦
|
Lms24
approved these changes
Feb 17, 2023
Lms24
reviewed
Feb 17, 2023
| @@ -298,11 +298,14 @@ jobs: | |||
| path: ${{ env.CACHED_BUILD_PATHS }} | |||
| key: ${{ env.BUILD_CACHE_KEY }} | |||
| - name: Check bundle sizes | |||
| uses: getsentry/size-limit-action@main-skip-step | |||
| uses: getsentry/size-limit-action@runForBranch | |||
There was a problem hiding this comment.
We'll need to change this once the PR is merged and the branch is deleted, right?
There was a problem hiding this comment.
jup, although the previous state was also still using the branch 😅 but yes, def should do a new "release" then. But I'll wait on billy to review there first.
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| 1cf8988 | +53.81 ms | -0.00 ms | +4.80 pp | +929.88 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +91.07 ms |
| 68655e3 | +72.60 ms | +0.00 ms | +7.90 pp | +922.72 kB | +1.04 MB | +2.22 kB | +41 B | +1 | +109.40 ms |
| a8449de | +58.27 ms | -0.00 ms | +7.12 pp | +927.42 kB | +1.05 MB | +2.2 kB | +41 B | +1 | +98.31 ms |
| 79babe9 | +58.69 ms | -0.00 ms | +4.40 pp | +927.46 kB | +1.06 MB | +2.23 kB | +41 B | +1 | +103.20 ms |
| 5359ba9 | +55.62 ms | -0.00 ms | +4.29 pp | +935.26 kB | +1.05 MB | +2.2 kB | +41 B | +1 | +79.05 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 17 Feb 2023 11:00:54 GMT
Last updated: Fri, 17 Feb 2023 11:00:54 GMT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on getsentry/size-limit-action#8, this ensures we can actually run size-limit on release branches, which currently fails.