fix(replay): Do not depend on event.type to infer isCheckout
#7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relies on getsentry/rrweb#56 to be merged & released first.
billyvg
reviewed
Feb 21, 2023
| @@ -534,17 +534,16 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| // when an error occurs. Clear any state that happens before this current | |||
| // checkout. This needs to happen before `addEvent()` which updates state | |||
| // dependent on this reset. | |||
| if (this.recordingMode === 'error' && event.type === 2) { | |||
| if (this.recordingMode === 'error' && isCheckout) { | |||
There was a problem hiding this comment.
Will this impact the behavior of start/stop recording in any way? I believe we should have test coverage around it
There was a problem hiding this comment.
So right now it will, because we do not always have isCheckout === true on initial snapshots. So we would need to to merge getsentry/rrweb#56 in first to make this work as expected, I think.
|
Replaced by #7321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on getsentry/rrweb#56 to be merged & released first.
Currently, checking the
typeof the event is a bit brittle to infer if something is happening (e.g. the "checkout" event is often of type 4 and happens before thetype 2full snapshot).This is a requirement to get something like getsentry/rrweb#55 landed, as that can trigger more full snapshots (without being a checkout), which in turn would lead to the error recording stuff not working as expected here.