Skip to content

chore(angular-ivy): Add release registry config for @sentry/angular-ivy #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2023
Merged

chore(angular-ivy): Add release registry config for @sentry/angular-ivy #7303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd45178
chore(angular-ivy): Add release registry config for `@sentry/angular-…
Lms24 Mar 1, 2023
f69929c
adjust regexes
Lms24 Mar 1, 2023
a54a553
make regexes more explicit for all packages
Lms24 Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,28 +25,30 @@ targets:
- name: registry
sdks:
'npm:@sentry/browser':
onlyIfPresent: /^sentry-browser-.*\.tgz$/
onlyIfPresent: /^sentry-browser-\d.*\.tgz$/
includeNames: /\.js$/
checksums:
- algorithm: sha384
format: base64
'npm:@sentry/node':
onlyIfPresent: /^sentry-node-.*\.tgz$/
onlyIfPresent: /^sentry-node-\d.*\.tgz$/
'npm:@sentry/react':
onlyIfPresent: /^sentry-react-.*\.tgz$/
onlyIfPresent: /^sentry-react-\d.*\.tgz$/
'npm:@sentry/vue':
onlyIfPresent: /^sentry-vue-.*\.tgz$/
onlyIfPresent: /^sentry-vue-\d.*\.tgz$/
'npm:@sentry/gatsby':
onlyIfPresent: /^sentry-gatsby-.*\.tgz$/
onlyIfPresent: /^sentry-gatsby-\d.*\.tgz$/
'npm:@sentry/angular-ivy':
onlyIfPresent: /^sentry-angular-ivy-\d.*\.tgz$/
'npm:@sentry/angular':
onlyIfPresent: /^sentry-angular-.*\.tgz$/
onlyIfPresent: /^sentry-angular-\d.*\.tgz$/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this would be a bit more explicit:

/^sentry-angular-(?!ivy-).*\.tgz$/

Copy link
Member Author

@Lms24 Lms24 Mar 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure, this would actually be safer than the \d regex. Cause theoretically (not saying this happens but nevertheless) sentry-angular-somethingotherthanivy-7.39.0.tgz would be matched by this regex.

Anyway, I think we're safe with the two current regexes so I'd keep it this way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, yeah, sure, but that also applies to any other package regex we have :D

Maybe it would be better for consistency to then update all regexes to have the \d part? My main concern is that it may be unclear in the future why this is slightly different then the others, you copy-paste one of them (which one?) etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all other packages a54a553

'npm:@sentry/wasm':
onlyIfPresent: /^sentry-wasm-.*\.tgz$/
onlyIfPresent: /^sentry-wasm-\d.*\.tgz$/
'npm:@sentry/nextjs':
onlyIfPresent: /^sentry-nextjs-.*\.tgz$/
onlyIfPresent: /^sentry-nextjs-\d.*\.tgz$/
'npm:@sentry/remix':
onlyIfPresent: /^sentry-remix-.*\.tgz$/
onlyIfPresent: /^sentry-remix-\d.*\.tgz$/
'npm:@sentry/svelte':
onlyIfPresent: /^sentry-svelte-.*\.tgz$/
onlyIfPresent: /^sentry-svelte-\d.*\.tgz$/
'npm:@sentry/opentelemetry-node':
onlyIfPresent: /^sentry-opentelemetry-node-.*\.tgz$/
onlyIfPresent: /^sentry-opentelemetry-node-\d.*\.tgz$/