Skip to content

ref(replay): Use Date.now() instead of new Date().getTime() #7492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 16, 2023

This is slightly shorter and should actually be slightly more performant.

This is slightly shorter and should actually be slightly more performant.
@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Mar 16, 2023
@mydea mydea requested review from billyvg and Lms24 March 16, 2023 17:36
@mydea mydea self-assigned this Mar 16, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.46 KB (-0.14% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.38 KB (-0.18% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.07 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.43 KB (+0.07% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.72 KB (+0.09% 🔺)
@sentry/browser - Webpack (minified) 67.65 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.74 KB (+0.09% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.2 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.72 KB (-0.13% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.86 KB (-0.03% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.94 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.06 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.12 KB (0%)

@mydea mydea merged commit 873d9bb into develop Mar 17, 2023
@mydea mydea deleted the fn/date-now branch March 17, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants