-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(sveltekit): Add SvelteKit routing instrumentation #7565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Mar 22, 2023
AbhiPrasad
approved these changes
Mar 22, 2023
4fdaecd
to
846eae6
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add routing instrumentation to the client SvelteKit SDK. Pageload navigations are created on function call as always and updated with a proper name once the
page
store emits the route id. Navigation transactions are created by subscribing to thenavigating
store. No need for user configuration, as the instrumentation will be added automatically on SDK intialization.I had to adjust test a bunch because the SvelteKit
$app/stores
import doesn't work in a non-SvelteKit app build (like in our unit tests). The unit tests aren't great but they're at least testing the instrumentation code itself. We'll need to add integration tests later on.ref #7413